search

arb / celebrate

A joi validation middleware for Express.
MIT License
1.33k stars 66 forks source link

fix(typings): ValidationResult is not generic #143

Closed Meemaw closed 4 years ago

Meemaw commented 4 years ago

Fixes https://github.com/arb/celebrate/issues/142

codecov-io commented 4 years ago

Codecov Report

Merging #143 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #143   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          65     65           
  Branches       11     11           
=====================================
  Hits           65     65

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2eadb92...9df3097. Read the comment docs.

arb commented 4 years ago

I've already got a change for this in #140. format in version 11 takes only a Joi error. What version of celebrate are you currently using, 10.1.0? If you want to backport this change, you'll need to open a PR against that tag and not master.

arb commented 4 years ago

Closing due to inactivity