search

arb / celebrate

A joi validation middleware for Express.
MIT License
1.34k stars 65 forks source link

Fix declare issues #150

Closed kdankert closed 4 years ago

kdankert commented 4 years ago

Fixes #149

Removed false declare modifiers in the typescript declaration file. This is only important for v11 as this issue doesn't exist in v10 or at least I had no problems with it.

Is there anything else that change because of the v11 Update. Error changed, so the CelebrateError class in the index.d.ts might not be important anymore. I would need to know how errors exactly work now.

I'll open this as a draft to make some changes if changes need to be done.

codecov-io commented 4 years ago

Codecov Report

Merging #150 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #150   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          68     68           
  Branches       11     11           
=====================================
  Hits           68     68

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0a1b86...64caefd. Read the comment docs.

arb commented 4 years ago

Trumped by #152