search

arb / celebrate

A joi validation middleware for Express.
MIT License
1.33k stars 66 forks source link

Joi Version Bump #162

Closed arb closed 4 years ago

arb commented 4 years ago

Bump to version 17.

https://github.com/hapijs/joi/issues/2262

Kamahl19 commented 4 years ago

Joi 17 only supports Node 12+ but Celebrate seems to require Node 10+. Will Joi work on node 10 as well?

arb commented 4 years ago

joi got rid of the engine value in it's package.json, so it's hard to know. You could try it and see what happens, in all likelihood though, I'll update celebrates engine value to match what joi is testing for (which is probably 12 and the next major)

Kamahl19 commented 4 years ago

Just trying it out is not enough, it could break in just some usecase of Joi. Wouldnt it be better to stay on older Joi, the one that supports node 10? This crazy move Hapi did to cut node 10 a year before it goes out of LTS it not good.

arb commented 4 years ago

One of the project goals of celebrate is to keep joi updated with latest. I agree with you though on principle, I don't like the speed that "old" versions of Node are deprecated in the hapi ecosystem, but there really isn't anything I can do about it.

If you want to use an older version of Joi, roll back to version 11 of celebrate. That used a version that was supported in Node 10.