New Internals - Githubissues

After staring at the main validation path for a few hours, I realized a lot of this code is more complex than it really needed to be.

Biggest changes:

Reuse the same array on every request. This way, I'm not creating single use arrays that need to be GCed after every run.
Stop creating new promises on every validation and instead let Joi do this (I don't think's a real promise, but it behaves like one)
Change validateBody to be a closure to keep a curried copy of validateSegment around so we only need to create this once.
Changed the main validation path to use [].reduce(() =>{}, Promise.resolve(null) rather than the recursive way it used to be.
Precompile all the schemas outside of the middleware so it only happens once per invocation of celebrate() not every time the request is validated

Benchmarks

These values come from node utils/benchmark:

pre-change

valid x 32,945 ops/sec ±5.60% (77 runs sampled) invalid x 23,976 ops/sec ±1.96% (85 runs sampled)

valid x 37,814 ops/sec ±1.73% (80 runs sampled) invalid x 24,608 ops/sec ±2.28% (85 runs sampled)

valid x 31,047 ops/sec ±8.14% (78 runs sampled) invalid x 24,413 ops/sec ±2.22% (82 runs sampled)

after-change

valid x 350,009 ops/sec ±1.76% (73 runs sampled) invalid x 337,577 ops/sec ±4.04% (72 runs sampled)

valid x 343,469 ops/sec ±5.65% (27 runs sampled) invalid x 205,444 ops/sec ±4.48% (26 runs sampled)

valid x 385,833 ops/sec ±2.49% (53 runs sampled) invalid x 353,932 ops/sec ±6.53% (72 runs sampled)

Unless I'm doing something incredibly wrong, that's an order of magnitude faster 😮

arb / celebrate

New Internals #168

Biggest changes:

Benchmarks

Codecov Report