search

arb / celebrate

A joi validation middleware for Express.
MIT License
1.33k stars 66 forks source link

Adjust Engine Value #169

Closed arb closed 4 years ago

arb commented 4 years ago

Joi only tests against 12 and "node" so I should update accordingly.

izolate commented 4 years ago

Hi @arb - I understand the reasoning behind this change, but unfortunately this prevents the use of celebrate in Google Cloud Functions (GCF). The latest supported runtime on GCF is Node v10, so celebrate now refuses to install due to the engine version limitation.

Perhaps you could consider dropping it back to v10 until GCF supports a more recent runtime? Otherwise the workaround is to use celebrate@12.0.1

arb commented 4 years ago

Does GCF require an engine value? If not, I could just omit it entirely and leave it on the consumer to deal with it? Frankly, it's a huge pain to keep up-to-date anyway.

izolate commented 4 years ago

@arb No, the engine is not required and omitting it will allow the package to be installed on any Node version. That's a decision that I'll leave up to you.