search

arb / celebrate

A joi validation middleware for Express.
MIT License
1.33k stars 66 forks source link

Move dependencies from @hapi/joi to joi #184

Closed spyndutz closed 4 years ago

spyndutz commented 4 years ago

According to this issue, Joi is leaving @hapi I updated the dependencies reflecting the contributor's stated request Replace @hapi/joi with joi in your package.json files and your require statement.

codecov-commenter commented 4 years ago

Codecov Report

Merging #184 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #184   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           64        64           
  Branches        10        10           
=========================================
  Hits            64        64
Impacted Files Coverage Δ
lib/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 68efa08...3ff60dd. Read the comment docs.

arb commented 4 years ago

Thanks for this PR! Since the error changed while changing the version of Joi, that technically makes it a breaking change. I've kicked off a version 13 milestone and it would be great to open a similar PR against #185 rather than master?