Closed jasmine-q closed 3 years ago
It sure is!! Thanks for reporting. I've got a simple fix locally. I think I will make this a breaking change in case people were using it in the broken state before. What are your thoughts?
Hey @jasmine-q, can you give #216 a spin when you get a minute? Does that solve your issue?
Hey @jasmine-q, can you give #216 a spin when you get a minute? Does that solve your issue?
Hi @arb, sorry I didn't get back to you earlier. Yes that's working great for me and solves my issue, thanks for the quick reply and fix!
Making this a breaking change makes sense to me 👍
node
version - v10.14.1celebrate
version - 13.0.4joi
version (vianpm ls --depth=0 | grep joi
) - 17.3.0Here is an example value that is not working as expected:
Running
celebrator({ reqContext: true, mode: Modes.FULL }, { convert: false })(schema)
results in:Running
celebrator({ reqContext: true, mode: Modes.FULL }, { convert: false }, schema)
results in:However,
celebrator({ reqContext: true, mode: Modes.FULL })({ convert: false })(schema)
works!The issue I am having with
celebrate
is:celebrator
isn't able to be used in all the ways listed in the docs: