search

arb / celebrate

A joi validation middleware for Express.
MIT License
1.34k stars 65 forks source link

Chore - Node v4 removed from CI #71

Closed rimiti closed 6 years ago

rimiti commented 6 years ago

Hello,

I've removed Node v4 from CI because Jest only support >= v6.0.0 (Jest documentation)

Have a nice day,

arb commented 6 years ago

The current project goal is to support Express 4 and 5 (when it comes out) so Node 4 support and testing is still required and can't be dropped from the support Matrix.

I certainly want to drop Node 4, but I can't as long as Express continues to support it.

rimiti commented 6 years ago

Hello @arb,

I'm agree with you but jest doesn't support Node v4... Your tests will always crash. The goal of this PR was just to remove node 4 "only" from CI.

Regards,

arb commented 6 years ago

They only crash because you changed the version of Jest though. If we keep the version of Jest that supports Node 4; everything is fine. While it would be nice to just drop Node 4 from the test Matrix, I'm not sure how I feel about saying something "works" in Node 4, but have 0 tests for it.