search

arbeitsgruppe-digitale-altnordistik / Sammlung-Toole

A new look on Handrit.is data
https://arbeitsgruppe-digitale-altnordistik.github.io/Sammlung-Toole/
MIT License
0 stars 0 forks source link

refactor: decouple database from sqlite #108

Closed BalduinLandolt closed 2 years ago

BalduinLandolt commented 2 years ago

The direct dependency of our database API on an SQLite connection makes testing hard.

This PR resolves this issue by decoupling this dependency.

resolves #107

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 24 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kraus-s commented 2 years ago

This looks good to me, thank you! There is only one thing I am not sure about: We were running into trouble with cursors that were not properly closed at some point in the past. But I hope that this should be irrelevant for read only operations. Let's keep this in mind in case we run into any trouble.