BalduinLandolt commented 2 years ago

in this PR I tried out the multi-page support that streamlit provides since version 1.10.
The git diff is a bit misleading, I mostly shuffled code around from the interface.py file to other files. Apart from that I did some minor improvements, but nothing of great impact.

IMO it doesn't look bad with those pages. But as this is a matter of taste, I'd open it for discussion if we want that at all.
Also, it would be great to test if still everything works as expected. (I had to do some stuff with streamlit states and caching, which is still rather cryptic to me, so it might well be that I broke something...)

BalduinLandolt commented 2 years ago

There is a bug with the groups not updating in the UI, caused by a caching issue. The easiest way to fix this, is to implement the database solution for groups (#103 ) and leave this PR open as a draft for now.

codecov-commenter commented 2 years ago

Codecov Report

Base: 39.38% // Head: 42.86% // Increases project coverage by +3.47% :tada:

Coverage data is based on head (2fd3eec) compared to base (746ff42). Patch coverage: 97.93% of modified lines in pull request are covered.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #109 +/- ## ========================================== + Coverage 39.38% 42.86% +3.47% ========================================== Files 25 25 Lines 1508 1570 +62 ========================================== + Hits 594 673 +79 + Misses 914 897 -17 ``` | [Impacted Files](https://codecov.io/gh/arbeitsgruppe-digitale-altnordistik/Sammlung-Toole/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arbeitsgruppe-digitale-altnordistik) | Coverage Δ | | |---|---|---| | [src/lib/metadatahandler.py](https://codecov.io/gh/arbeitsgruppe-digitale-altnordistik/Sammlung-Toole/pull/109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arbeitsgruppe-digitale-altnordistik#diff-c3JjL2xpYi9tZXRhZGF0YWhhbmRsZXIucHk=) | `34.61% <50.00%> (+1.28%)` | :arrow_up: | | [src/lib/stateHandler.py](https://codecov.io/gh/arbeitsgruppe-digitale-altnordistik/Sammlung-Toole/pull/109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arbeitsgruppe-digitale-altnordistik#diff-c3JjL2xpYi9zdGF0ZUhhbmRsZXIucHk=) | `100.00% <100.00%> (+20.00%)` | :arrow_up: | | [src/lib/utils.py](https://codecov.io/gh/arbeitsgruppe-digitale-altnordistik/Sammlung-Toole/pull/109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arbeitsgruppe-digitale-altnordistik#diff-c3JjL2xpYi91dGlscy5weQ==) | `53.70% <100.00%> (ø)` | | | [tests/unit/lib/test\_state\_handler.py](https://codecov.io/gh/arbeitsgruppe-digitale-altnordistik/Sammlung-Toole/pull/109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arbeitsgruppe-digitale-altnordistik#diff-dGVzdHMvdW5pdC9saWIvdGVzdF9zdGF0ZV9oYW5kbGVyLnB5) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arbeitsgruppe-digitale-altnordistik). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arbeitsgruppe-digitale-altnordistik)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.