kraus-s commented 2 years ago

Tabs for displaying search results to improve UX. "Normal" search page has all search features with the new layout. "Experimental" search also has the new backend using improved flow with st.empty(). Idea: result_view() should be able to handle all result types or at least all that show MS metadata, because they are essentially the same, only the headline differs, so we shouldn't need three separate functions. Cf #117

BalduinLandolt commented 2 years ago

Nice, good job!
I'll have a detailed look at the code, once you mark it as "ready for review", ok?

Sonar reports a number of bugs in the experimental search file; and tests seem to fail, so it's probably right. Maybe worth looking at?

Other than that I'm curious to try it out, once it's ready! :D

codecov-commenter commented 2 years ago

Codecov Report

Base: 44.23% // Head: 44.40% // Increases project coverage by +0.16% :tada:

Coverage data is based on head (562dc66) compared to base (36665dd). Patch coverage: 43.75% of modified lines in pull request are covered.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #120 +/- ## ========================================== + Coverage 44.23% 44.40% +0.16% ========================================== Files 25 25 Lines 1519 1527 +8 ========================================== + Hits 672 678 +6 - Misses 847 849 +2 ``` | [Impacted Files](https://codecov.io/gh/arbeitsgruppe-digitale-altnordistik/Sammlung-Toole/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arbeitsgruppe-digitale-altnordistik) | Coverage Δ | | |---|---|---| | [src/lib/xml/metadata.py](https://codecov.io/gh/arbeitsgruppe-digitale-altnordistik/Sammlung-Toole/pull/120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arbeitsgruppe-digitale-altnordistik#diff-c3JjL2xpYi94bWwvbWV0YWRhdGEucHk=) | `8.93% <0.00%> (ø)` | | | [src/lib/xml/tamer.py](https://codecov.io/gh/arbeitsgruppe-digitale-altnordistik/Sammlung-Toole/pull/120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arbeitsgruppe-digitale-altnordistik#diff-c3JjL2xpYi94bWwvdGFtZXIucHk=) | `13.16% <0.00%> (ø)` | | | [src/lib/datahandler.py](https://codecov.io/gh/arbeitsgruppe-digitale-altnordistik/Sammlung-Toole/pull/120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arbeitsgruppe-digitale-altnordistik#diff-c3JjL2xpYi9kYXRhaGFuZGxlci5weQ==) | `22.61% <33.33%> (ø)` | | | [src/lib/metadatahandler.py](https://codecov.io/gh/arbeitsgruppe-digitale-altnordistik/Sammlung-Toole/pull/120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arbeitsgruppe-digitale-altnordistik#diff-c3JjL2xpYi9tZXRhZGF0YWhhbmRsZXIucHk=) | `38.70% <50.00%> (+4.09%)` | :arrow_up: | | [src/lib/database/groups\_database.py](https://codecov.io/gh/arbeitsgruppe-digitale-altnordistik/Sammlung-Toole/pull/120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arbeitsgruppe-digitale-altnordistik#diff-c3JjL2xpYi9kYXRhYmFzZS9ncm91cHNfZGF0YWJhc2UucHk=) | `89.13% <100.00%> (+0.75%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arbeitsgruppe-digitale-altnordistik). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arbeitsgruppe-digitale-altnordistik)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.