Closed ElineElmiger closed 3 years ago
I'll look into it, thanks.
Were you on the server or did you run it locally? And if locally, what branch?
Locally, and the main branch. Now I just started it again and stuff just started happening somehow? I think it's just continuing at the datahandler-part, now I'm curious to see what'll happen... (Edit: got the same error message again)
yea, I feared so... main branch has not got any love lately (mea maxima culpa) but once the current release candidate is ready, I hope this will be resolved. Sorry about that!
If you want something working sooner, you may want to try with the stable
branch
Thanks!
It appears to be fixed in RC/prepare RC, can I close this issue?
Sure! I'm actually a bit confused about some things, but I'll try to figure it out and else ask on Wednesday.
If you have questions, don't hesitate to ask! :)
Also, if you're on the prepareRC branch, to get full functionality, you should remove the data/funnel/xml.zip
file and rename xml-Copy.zip
to xml.zip
(and then wipe cache and rebuild handler, if you already ran it).
I reduced the number of XML files for development to speed up things. But that means that you can only find very few manuscripts at the moment.
Thanks for the explanation! I think that answers all of my questions :D Had to re-download the code and run "Reload Data Handler" twice because I got an error message the first time. But now it works, which is really cool!
I got the following error message when trying the "Download everything" button (the problem seems to be in the datahandler part where it should be getting manuscript info?).
Feel free to delete or close the issue if it's an error on my part!
TypeError: unsupported operand type(s) for +: 'int' and 'str' Traceback: File "C:\Users\eline\AppData\Local\Programs\Python\Python39\lib\site-packages\streamlit\script_runner.py", line 337, in _run_script exec(code, module.dict) File "C:\Users\eline\Downloads\Sammlung-Toole-main\Sammlung-Toole-main\interface.py", line 420, in
full_menu()
File "C:\Users\eline\Downloads\Sammlung-Toole-main\Sammlung-Toole-main\interface.py", line 399, in full_menu
get_handler()
File "C:\Users\eline\Downloads\Sammlung-Toole-main\Sammlung-Toole-main\interface.py", line 78, in get_handler
adv_options()
File "C:\Users\eline\Downloads\Sammlung-Toole-main\Sammlung-Toole-main\interface.py", line 151, in adv_options
rebuild_all_button()
File "C:\Users\eline\Downloads\Sammlung-Toole-main\Sammlung-Toole-main\interface.py", line 90, in rebuild_all_button
rebuild_handler(xmls, contents)
File "C:\Users\eline\Downloads\Sammlung-Toole-main\Sammlung-Toole-main\interface.py", line 103, in rebuild_handler
state.data_handler = DataHandler.get_handler(xmls=xmls, contents=contents, prog=container)
File "C:\Users\eline\Downloads\Sammlung-Toole-main\Sammlung-Toole-main\datahandler.py", line 130, in get_handler
res = cls(max_res=max_res, prog=prog, xmls=xmls, contents=contents)
File "C:\Users\eline\Downloads\Sammlung-Toole-main\Sammlung-Toole-main\datahandler.py", line 28, in init
self.manuscripts = manuscripts if manuscripts else DataHandler._load_ms_info(max_res=max_res, prog=prog, df=xmls, contents=contents)
File "C:\Users\eline\Downloads\Sammlung-Toole-main\Sammlung-Toole-main\datahandler.py", line 88, in _load_ms_info
msinfo = df['soup'].progress_apply(tamer.get_msinfo)
File "C:\Users\eline\AppData\Local\Programs\Python\Python39\lib\site-packages\tqdm\std.py", line 810, in inner
return getattr(df, df_function)(wrapper, *kwargs)
File "C:\Users\eline\AppData\Local\Programs\Python\Python39\lib\site-packages\pandas\core\series.py", line 4108, in apply
mapped = lib.map_infer(values, f, convert=convert_dtype)
File "pandas_libs\lib.pyx", line 2467, in pandas._libs.lib.map_infer
File "C:\Users\eline\AppData\Local\Programs\Python\Python39\lib\site-packages\tqdm\std.py", line 805, in wrapper
return func(args, **kwargs)
File "C:\Users\eline\Downloads\Sammlung-Toole-main\Sammlung-Toole-main\handrit_tamer_2.py", line 63, in get_msinfo
folio = metadata.get_folio(soup)
File "C:\Users\eline\Downloads\Sammlung-Toole-main\Sammlung-Toole-main\metadata.py", line 387, in get_folio
log.warning(folio_total + ": Attention. Check number of folios.")