search

arbelt / fish-plugin-scmpuff

2 stars 3 forks source link

arg escaping problem with fish 2.7.0? #1

Open paulirish opened 6 years ago

paulirish commented 6 years ago

since upgrading to fish 2.7.0 i've been getting errors randomly like this:

image

in my setup, i can repro if i have a dirty git tree, i type git diff and hit tab, to get completion going.

I'm not exactly sure why we lose the quotes around the alias/..* string too early... but i guess that's what's happening.

ohayon commented 6 years ago

I am seeing this same issue when I do anything that could have a completion, for example: git checkout [tab] causes the same sort of output:


‣ git checkout - (line 1): No matches for wildcard 'alias\..*'. See `help expand`.
begin; command hub config -z --get-regexp alias\..* 
                                          ^
from sourcing file -
    called on line 60 of file /usr/local/Cellar/fish/2.7.1/share/fish/functions/eval.fish

in function 'eval'
    called on line 32 of file ~/.config/fish/conf.d/scmpuff.fish

in function 'git'
    called on line 154 of file /usr/local/Cellar/fish/2.7.1/share/fish/completions/git.fish
    with parameter list 'config -z --get-regexp alias\..*'

from sourcing file /usr/local/Cellar/fish/2.7.1/share/fish/completions/git.fish
    called on standard input

in command substitution
    called on standard input```
jdelStrother commented 5 years ago

I think this needs fixing upstream in scmpuff. I've submitted https://github.com/mroth/scmpuff/pull/44 to attempt to fix it.