arbitrari / testube

fullscreen entertainment options for your tesla
https://testube.app
GNU General Public License v3.0
65 stars 26 forks source link

Fullscreen Notification not showing #30

Closed DwieDave closed 2 years ago

DwieDave commented 2 years ago

Hi,

i've updated my Model 3 to 2022.16.3 today and wanted to test the browser performance with testube but the Fullscreen toast notification did not show up and therefore apps like A better Routeplanner did not load in Fullscreen.

Is there a known bug at the moment?

Regards

JaxonWright commented 2 years ago

Hello @DwieDave,

Could you please:

1) Click on the build hash in the bottom middle of the screen. (Where the fullscreen notification usually is) image

2) Click the copy button on the end of the UserAgent field, and paste it in here?
image

I am on the FSD beta, so I can only go make sure it works on my software and its hard to test other configs without knowing that information.

Thanks

JaxonWright commented 2 years ago

Related to #27

DwieDave commented 2 years ago

The build shown is from June 20 (Hash fafc18a) I really dont know how to paste from the tesla (is it even possible?)

I've taken a picture and used OCR:

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36 Tesla/feature-2022.16.3-391-cedf22462e

EDIT: The regex pattern you used in the app.component.ts is not matching with my userAgent String and therefore not showing the SnackBar.

This regex would match my userAgent as well: Tesla\/(develop-)*(feature-)*(?:.*fsd.*)*([0-9]{4}.[0-9]{1,3}.?[0-9]{0,3}.?[0-9]{0,3}.?[0-9]{0,3})*-(.*)

JaxonWright commented 2 years ago

I really dont know how to paste from the tesla (is it even possible?)

I think you can just long-press in a text area. I guess I should try it before telling people to do it haha.

Thanks for going above and beyond. I'll look into fixing it tonight! They keep adding words to the string, making it hard to account for everything. Your new RegEx should work well upon just glancing at it.

DwieDave commented 2 years ago

I've tried the iOS tap and hold gesture in every possible way and nothing showed up. Thanks for the fast reply.

Just out of curiosity: Why do you show the SnackBar only in a Tesla Browser?

JaxonWright commented 2 years ago

I've tried the iOS tap and hold gesture in every possible way and nothing showed up.

OK, I'll have to think of a different way for people to report this kind of info, then :\

Just out of curiosity: Why do you show the SnackBar only in a Tesla Browser?

Because that is the only browser that the action actually does anything on. I also need to detect the Tesla browser to apply some scaling to the site that reverses something that Tesla does to every site in their browser when in Theater Mode. They apply a zoom to it that was messing with things in fullscreen.

JaxonWright commented 2 years ago

@DwieDave fixed now. Thanks again for the help!

DwieDave commented 2 years ago

Thanks for your fast update! The Snackbar is now showing and fullscreen mode is working but now I have another bug (issue #33).