arboleya / coffee-toaster

Minimalist build system for CoffeeScript.
114 stars 23 forks source link

Latest version of node.js (v0.10.0) breaks coffee-toaster #64

Closed zslayton closed 11 years ago

zslayton commented 11 years ago

The same coffee.toaster file has been working in node v.0.8.17. I upgraded today and found that trying to run either 'toaster -w' or 'toaster -c' would cause the following:

bash-3.2$ toaster -w

path.js:313 throw new TypeError('Arguments to path.resolve must be strings'); ^ TypeError: Arguments to path.resolve must be strings at Object.exports.resolve (path.js:313:15) at Toast.__t.Toast.Toast.toast (/usr/local/lib/node_modules/coffee-toaster/lib/toaster.js:104:23) at Toast.toast (/usr/local/lib/node_modules/coffee-toaster/lib/toaster.js:27:61) at Toast.eval (eval at Toast (/usr/local/lib/node_modules/coffee-toaster/lib/toaster.js:90:16), :2:6) at new Toast (/usr/local/lib/node_modules/coffee-toaster/lib/toaster.js:90:11) at new Toaster (/usr/local/lib/node_modules/coffee-toaster/lib/toaster.js:1354:22) at Object.exports.run (/usr/local/lib/node_modules/coffee-toaster/lib/toaster.js:1296:12) at Object. (/usr/local/lib/node_modules/coffee-toaster/bin/toaster:7:27) at Module._compile (module.js:456:26) at Object.Module._extensions..js (module.js:474:10)

arboleya commented 11 years ago

I'll take a look.

geowarin commented 11 years ago

I ran into the same error with a freshly installed toaster. I think error is not in node, but rather is a misplaced parenthesis in lib/toaster.js at line 104.

It reads : else if (path.resolve(srcpath !== srcpath)) when it should probably be : else if (path.resolve(srcpath) !== srcpath)

arboleya commented 11 years ago

@geowarin You're right, I'm releasing a patch for each soon.