arboleya / electrify

Package your Meteor apps with Electron, and butter
MIT License
247 stars 52 forks source link

Settings cannot be set #28

Closed hyperh closed 8 years ago

hyperh commented 8 years ago

I'm having trouble getting the Meteor settings to work.

electrify -s settings.json doesn't seem to work for me. I've double checked that settings.json is in the right path when I run the command.

arboleya commented 8 years ago

@hyperh Hi, I don't recall any remaining problems with the settings, but I'll check. Tks for reporting.

hyperh commented 8 years ago

I did a console.log(Meteor.settings) on the server side. It returns { public: {} }

My Meteor settings are supposed to be:

{
  "public": {
    "test": "thisisatest"
  },

  "embedlyApiKey": "mykey"
}

Update: Even when I change my settings.json to only

{
}

My console.logreturns the same { public: {} }

arboleya commented 8 years ago

Yes, because the public namespace inside the settings object is automatically filled in by Meteor. ;)

coniel commented 8 years ago

Also having the same issue, tried starting is using both electrify -s settings.json and electrify --settings settings.json and not getting any settings.

arboleya commented 8 years ago

I've found the problem, it only occurs when developing, not after packaging the app.

I'm on it, should release this fix tomorrow.

arboleya commented 8 years ago

Fixed in 2.1.3, please update.

Closing, feel free to reopen in case something goes wrong.