arboleya / electrify

Package your Meteor apps with Electron, and butter
MIT License
247 stars 52 forks source link

Increased app size after upgrade to meteor 1.3 #49

Open ghost opened 8 years ago

ghost commented 8 years ago

Hi!

Since upgrade to meteor 1.3 (that uses a lot of npm modules now) my packaged app has grown to almost 400 mb (comparing to 200 on meteor 1.2). File count is up to 27,000 (twenty sevent bloody thousands) comparing to ~7000 on meteor 1.2, some of them exceed windows file path limit. Well, it's kind a frustrating now to wait for 20 minutes (twenty!) to package app. How can I reduce file count? Possible solutions:

PS: from electron-packager readme:

Be careful not to include node_modules you don't want into your final app. electron-packager, electron-prebuilt and .git will be ignored by default. You can use --ignore to ignore files and folders via a regular expression. For example, --ignore=node_modules/package-to-ignore or --ignore="node_modules/(some-package[0-9]*|dev-dependency)".
zaverichintan commented 8 years ago

Same issues.. Meteor is becoming less user friendly day by day.

ghost commented 8 years ago

It's not about friendly or not. I think meteor devs have enough issues with new release to bother about bundle size.

Actually I thout that js minification will do reduce both file count and size, but with modules and nodes it is not the case anymore.

zaverichintan commented 8 years ago

It takes like 6 hours to create a new app in meteor 1.3.2 . It's kind of testing my patience .