arbor-sim / arbor

The Arbor multi-compartment neural network simulation library.
https://arbor-sim.org
BSD 3-Clause "New" or "Revised" License
108 stars 61 forks source link

Remove `simulation::inject_events` #2265

Closed thorstenhater closed 6 months ago

thorstenhater commented 6 months ago

This removes simulation::inject_events which is made obsolete by recipe::event_generators. The method exposed internals by giving access to the lid of synapses (over labels) and broke abstractions (gid must be present on this MPI rank and all events must be deliverable during the current time (as per documentation)). It was used only in a few tests and examples and these uses were replaced by event_generators.

bcumming commented 6 months ago

I vaguely remember adding this in the early days of development, probably pre dating the event generators. It would have been used for unit testing, and is no longer needed.