Fix CI

[brenthuisman]

• Update Arbor to v0.8
  • Update for some minor API changes therein.
• Simplify and fix CI
  • PR workflow now also builds AppImage/DiskIm, since it's a small overhead
  • No more Nightly because of that
  • Tell CMake to -DBUILD_SHARED_LIBS=OFF, to cope with a submodule (glm) incorrectly globally setting this, causing lib packaging errors when building AppImage/DiskImages.
  • Break out the AppImage script into workflow steps, to help troubleshoot breakage.
  • Update minimum build-OSes; GitHub have deprecated the macos-10.15 and ubuntu-18.04 runners.

[brenthuisman]

On BUILD_SHARED_LIBS before add_subdirectory(glfw): you mean instead of passing the flag to CMake?

The lib messing stuff up is glm, not glfw. But I can't find a add_subdirectory(glm) anywhere in the project, only target_include_directories(arbor-gui-deps SYSTEM INTERFACE 3rd-party/glm) (header only?). Would setting it before this line be what you want to try?

[thorstenhater]

Yes glm is header only, so it cannot set BUILD_SHARED_LIBS=ON, because we never executed their CMake. Thus, glm cannot be the issue.

Also I use glm since the beginning of this project. glbinding is new though, so I start poking there and they seem to be the culprit

3rd-party/glbinding/CMakeLists.txt
86:option(BUILD_SHARED_LIBS              "Build shared instead of static libraries."                 ON)

[brenthuisman]

OK, let's see if that works.

[brenthuisman]

So, jobs are passing, AppImage #worksforme, but the DiskIm does not work on @thorstenhater's M1.