search

arborchat / muscadine

[legacy] The Arbor reference client implementation
Apache License 2.0
5 stars 2 forks source link

Build new releases on merge to master #80

Closed whereswaldon closed 5 years ago

whereswaldon commented 5 years ago

This pull request should configure TravisCI building and publishing a release each time we update the master branch. I have tested it as well as I know how to in an isolated environment. Unfortunately, the only way to see that works for sure is to merge it.

whereswaldon commented 5 years ago

Had to do some updates after posting, but I believe that it will work when we hit merge.

BitiTiger commented 5 years ago

Maybe you can fork the project and try it first?

On Jan 15, 2019, at 5:21 PM, Christopher Waldon notifications@github.com<mailto:notifications@github.com> wrote:

Had to do some updates after posting, but I believe that it will work when we hit merge.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/arborchat/muscadine/pull/80#issuecomment-454574208, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdlB5yjgFK0q7KyBBqAelJoH9lQjsjOWks5vDlRKgaJpZM4aA72O.

whereswaldon commented 5 years ago

Good suggestion. I'm doing that now

whereswaldon commented 5 years ago

Okay, that testing did reveal a problem in the Travis environment that I didn't anticipate. Thanks @Caton101. Here's an example of a Travis build that built a release using this code.

BitiTiger commented 5 years ago

Making Windows users download 7zip or another archive utility is very funny to me. I think we should use a file format that the native OS can support without any extra tools. For Windows, I suggest using the classic .zip file.

jwhett commented 5 years ago

@Caton101, I resemble that remark! 😆

BitiTiger commented 5 years ago

Should we delete this branch to prevent stale branches?