Improvement: Better searches

arborrow / montserrat

A retreat management application written in Laravel

12 stars 4 forks source link

Improvement: Better searches #433

Closed arborrow closed 4 years ago

arborrow commented 4 years ago

[x] Convert existing searches to make use of request (search:get and result:put)
[x] Consider appropriate validation for requests (for example string for email rather than email since you want to search for a partial email)
[x] Consider expanding searches to other models especially the Donation/Payment models
[x] Consider ways of making searches more dynamic with greater than, less than or equal options (review how phpMyAdmin handles this is search)

arborrow commented 4 years ago

[x] Review each controller unit test to make sure that the create and updates are using the proper request form

arborrow commented 4 years ago

After further thought, I want to use the request types to provide some validation; however, get makes more sense than a put.

arborrow commented 4 years ago

Discovered some orphaned payments of $0 amount and soft-deleted them with: UPDATE Donations_payment as p LEFT JOIN Donations as d ON (d.donation_id = p.donation_id) SET p.deleted_at = NOW() WHERE d.donation_id IS NULL AND p.deleted_at IS NULL