arborrow
commented
2 years ago A couple of minor improvements are sneaking in with this issue. During testing, it was clear that if Twilio was not enabled it breaks the ability to store and update contacts (parish, diocese, person, organization and vendor) because of the phone validation. I have added if statements so that if Twilio is not configured then the value for phone numbers must be a string. While all of the store and update requests have been fixed, I also need to add the if clauses to the testing request comparisons.
In addition, I decided to finally disable sending of 500 exceptions and other emails if the app environment is set to local. In production the emails should continue to be sent.
Identify various scenarios where the health of the database could be improved. For example, where there may be more than one primary address, phone number, etc. In general think of situations that cause breakage - non-zero payments with deleted donations, etc.