arborrow / montserrat

A retreat management application written in Laravel
12 stars 4 forks source link

Migrate to `spatie/laravel-html` #560

Closed arborrow closed 5 months ago

arborrow commented 5 months ago

This pull request includes the changes for migrating from the laravelcollective/html package to the spatie/laravel-html package. Feel free to commit any additional changes to the shift-108340 branch.

Before merging, you need to:

If you need help with your migration, check out the Human Shifts.

arborrow commented 5 months ago

:x: Shift detected calls to the selectYear and selectRange methods. While Spatie HTML has a select method, it does not automatically create the options range like LaravelCollective HTML.

Shift converted these with a placeholder function called options_range. You will need to add this function to your helpers file:

function options_range($start, $end): array
{
    return array_combine($range = range($start, $end), $range);
}
arborrow commented 5 months ago

:x: Shift found remaining references to the Form and Html facades provided by the laravelcollective/html package. You should review these references and manually convert them to their spatie/laravel-html equivalent or raw HTML to complete your migration.

arborrow commented 5 months ago

:alembic: This Shift is still being refined. Please report any issues or suggestions to shift@laravelshift.com. Your feedback is what helps improve the experience for everyone.

arborrow commented 5 months ago

HTML::image missing asset; breaks images from showing - reported to JMac to be fixed.