search

arborwallet / arbor-wallet

Arbor Wallet is a light Chia wallet (SPV) with a focus on user privacy and security.
https://www.arborwallet.com
Apache License 2.0
11 stars 6 forks source link

Feature/biometrics #30

Open TobiCrackIT opened 3 years ago

TobiCrackIT commented 3 years ago
scotopic commented 3 years ago

@TobiCrackIT - add a list of URLs where you got the icons

TobiCrackIT commented 3 years ago

@scotopic https://www.flaticon.com/free-icon/padlock_3064197?term=padlock&page=1&position=4&page=1&position=4&related_id=3064197&origin=search

https://www.flaticon.com/free-icon/fingerprint_2313181?term=fingerprint&page=1&position=4&page=1&position=4&related_id=2313181&origin=search

TobiCrackIT commented 2 years ago

@scotopic, this PR has been updated to make the biometrics feature work as required.

scotopic commented 2 years ago

Android bug

  1. Install app from scratch
  2. Create a new wallet
  3. Click settings > Enter pin
  4. Background the app
  5. Foreground the app ( see the pin entry screen )
    • EXPECTED: No back button is visible
    • ACTUAL: Back button visible and takes you to the Secret Phrase view
scotopic commented 2 years ago

iOS bug

  1. Settings > Enable "Unlock with biometrics"
  2. Once the auth view comes up > click Cancel
    • ACTUAL: Another view appears to be added on the stack. Can never cancel out to enter the PIN.
    • EXPECTED: Cancel should remove the biometrics dialog and allow access to the PIN UI
scotopic commented 2 years ago

iOS issue:

  1. Settings > Enable "Unlock with biometrics"
  2. Tap on "Unlock with biometrics" to disable and authenticate the biometrics.
    • EXPECTED: Biometrics is disabled once the user is authenticated.
    • ACTUAL: PIN UI is shown even after the biometrics is authenticated.
TobiCrackIT commented 2 years ago

@scotopic , the issues raised have been fixed