search

arborwallet / arbor-wallet

Arbor Wallet is a light Chia wallet (SPV) with a focus on user privacy and security.
https://www.arborwallet.com
Apache License 2.0
11 stars 6 forks source link

Feature/send chia #4

Closed TobiCrackIT closed 3 years ago

TobiCrackIT commented 3 years ago

Allow users send Chia to another Chia wallet

scotopic commented 3 years ago

Tapping "MAX" button should set the max possible based on the walletModel.balance ( which the smallest unit of measure is based on walletModel.fork.precision ). In our case, a new wallet should show walletModel.fork.precision (precision=12 for XCH) meaning an empty wallet will display walletModel.balance ( 0.000000000000 which is 12 zeros after the decimal )

scotopic commented 3 years ago

Bug: Can't type our numbers after "MAX" is set.

  1. Tap MAX button
  2. Tap the 7 number button
    • EXPECTED: I can change the last zero 0.000000000000 to 0.000000000007
    • ACTUAL: Button tap doesn't change the value.
scotopic commented 3 years ago

Recipient address should not be an editable text field and only supports "Tap to Paste Recipient Address" so you have to have something in the clipboard to be able to paste it in. Once pasted, we to show "invalid address" if it doesn't match the format walletModel.fork.ticker + 1 + 58 of [qpzry9x8gf2tvdw0s3jn54khce6mua7l]:

valid:

  1. xch1507yzrww3mh62zcfx9qxjgnsy5c2s66hfpaj3r0hej3et9gxddxqmksqsf

not valid

  1. xch507yzrww3mh62zcfx9qxjgnsy5c2s66hfpaj3r0hej3et9gxddxqmksqsff ( no 1 after xch )
  2. xcv1507yzrww3mh62zcfx9qxjgnsy5c2s66hfpaj3r0hej3et9gxddxqmksqsff ( xcv not a valid walletModel.fork.ticker )
  3. xch1507yzrww3mh62zcfx9qxjgnsy5c2s66hfpaj3r0hej3et9gxddxqmksqs ( length is not 58 of characters form dictionary [qpzry9x8gf2tvdw0s3jn54khce6mua7l] after xch1)
scotopic commented 3 years ago

Reset data entry fields when leaving the screen.

  1. Enter the XCH amount
  2. Tap to paste an address
  3. Tap "Back" navigation button
  4. Tap "Send" again
    • EXPECTED: All entry values reset
    • ACTUAL: All entry values persisted
TobiCrackIT commented 3 years ago

Bug: Can't type our numbers after "MAX" is set.

  1. Tap MAX button
  2. Tap the 7 number button
  • EXPECTED: I can change the last zero 0.000000000000 to 0.000000000007
  • ACTUAL: Button tap doesn't change the value.

This looks strange though. The clear button should be used to remove any values that needs to be changed

scotopic commented 3 years ago

For the balance box it should read: (logo) $walletModel.fork.name <space to fill the void> 0.000000000000 ($walletModel.fork.ticker).toUpperCase

scotopic commented 3 years ago

Bug: Can't type our numbers after "MAX" is set.

  1. Tap MAX button
  2. Tap the 7 number button
  • EXPECTED: I can change the last zero 0.000000000000 to 0.000000000007
  • ACTUAL: Button tap doesn't change the value.

This looks strange though. The clear button should be used to remove any values that needs to be changed

Hmm yeah even Coinbase doesn't allow changing once max numbers are entered. OK leave as is.

TobiCrackIT commented 3 years ago

@scotopic , the PR has been updated