arborworkflows / aRbor

aRbor, an R package with useful functions for Arbor workflows
5 stars 3 forks source link

Add select_ to support later dplyr #34

Open jeffbaumes opened 9 years ago

jeffbaumes commented 9 years ago

There are two problems when supporting R version 3.1:

Still to resolve

jeffbaumes commented 9 years ago

@uyedaj @lukejharmon Please take a look. I may be a bit out of my league in R programming but I gave it a shot.

jeffbaumes commented 9 years ago

I honestly have no idea what that conversion line does, so I didn't decompose to find the true issue. Indeed rownames seem to disappear somewhere in the conversion. I have also noticed that both in select_ and near the end of the make treedata there is a line that attempts to set rownames, but there is no effect (row names remain unset) and I have no idea why. If those lines worked, the conversion line could be kept in and the row names would just be set later. But as it is, on R 3.1 removing that conversion was the only place I could figure out how to keep rownames in place for downstream processing.

uyedaj commented 9 years ago

Ok, that makes sense. I'll look into how to make this more stable...