search

arborx / ArborX

Performance-portable geometric search library
BSD 3-Clause "New" or "Revised" License
184 stars 39 forks source link

Switch spheres to new hyper-dimensional ones #1146

Closed aprokop closed 1 month ago

aprokop commented 2 months ago

So, all the comments are about reinterpret_cast/bit_cast. The issues is that our algorithms require running algorithms or constructing ArborX geometry types from some other types. Often, these other types are provided by a user, and we convert them to something that internally we can digest. We could follow boost and explicitly construct internal data by using getters.

I think this is a larger discussion and is outside of the scope of this PR.

aprokop commented 1 month ago

@masterleinad I have a patch to address the conversion routines. Will do a separate PR after this one is merged.