search

arbrandt / OPGEE

Oil Production Greenhouse Gas Emissions Estimator
18 stars 4 forks source link

Another circular reference for bitumen #451

Closed qlangfitt closed 2 years ago

qlangfitt commented 2 years ago

Found another circular reference causing issues for bitumen API gravity. Stream 5 crude oil mass is calculated on Heavy Oil Upgrading (cell E12) and relies on the specific gravity calculated on the Flow Sheet (cell J32), but the flow sheet sg only calculates if the mass is positive.

Suggest solving by having Heavy Oil Upgrading E12 reference Heavy Oil Upgrading M62 rather than the flow table for sg. That way, the flow sheet still shows a blank if heavy oil upgrading is not used, but there's no circular reference issue.

arbrandt commented 2 years ago

Fixed. I am perhaps imaging this, but it seems that the model is more responsive now that we are removing circular refs.