Compatibility issues with Firefox 52

arbre-app / arbre.app

Website for arbre.app

https://arbre.app

MIT License

8 stars 0 forks source link

Compatibility issues with Firefox 52 #1

Open FlorianCassayre opened 2 years ago

FlorianCassayre commented 2 years ago

Windows XP users are encountering issues with Firefox 52.

A problem with the AbortController prevented the search altogether and was fixed in https://github.com/arbre-app/insee-deces-front/commit/b8d7463d0e5559020612c38fedb239224457cd34.

Now the service appears to work mostly correctly, but there are still some quirks:

Dropdowns are not working, clicking on them won't trigger any error but the menu doesn't appear
Values in pluralized strings are not injected; normal translated strings do not show any problem

FlorianCassayre commented 2 years ago

The dropdowns appear to work, up until the permalink button is clicked. At this point no dropdown/popover will ever show up again, until the webpage is refreshed. The DOM still seems to be updated though because I can can briefly see the id attribute of the popover appear when clicked.

FlorianCassayre commented 2 years ago

A similar problem (the same?) can also be reproduced on the latest version of Palemoon (reported by Alain A.).

Edit: this problem is reproducible in the development environment.

FlorianCassayre commented 2 years ago

The above problem appears to be: https://github.com/react-bootstrap/react-bootstrap/issues/5409 According to thread it is because of React 17, which this project is actually using. The proposed workaround is to add onClick={(e) => e.stopPropagation()} to the triggerer. This effectively fixes the issue with dropdowns/modals/popovers.

FlorianCassayre commented 2 years ago

The patch was deployed and after testing appears indeed to fix the first problem on both Palemoon and Firefox 52. The only problem remaining is the unparsed pluralized strings (this however is specific to Firefox 52, it does not occur on Palemoon).