arbyste / jp-mining-note

Temporary bugfix fork for JPMN
MIT License
31 stars 1 forks source link

Bug/yomichan to yomitan #21

Open edsml-jjl122 opened 2 weeks ago

edsml-jjl122 commented 2 weeks ago

Used VSCodes search function to find all instances of Yomichan or yomichan and replace them with Yomitan and yomitan respecively. Only replaced instances where the context of the change was clear.

I ignored .py and .js files in the search as I didn't want to mess with the code base. Some files (such as yomichantemplates.md) were changed to yomitantemplates.md and the docs/assets/yomichan folder was changed to docs/assets/yomitan. I did my best to make sure that links were not broken when referenced elsewhere.

arbyste commented 5 days ago

Thanks for looking into this! I'll go through and take a look soon. There were a handful of Yomichan occurrences that I wanted to leave as is for historical reasons (some of them were quotes from other people iirc) so I might need to revert some.

edsml-jjl122 commented 4 days ago

There were some quotes and I did my best to ignore them but I may have missed some. I did review each change individually so hopefully its not too much of a hassle. Thanks for keeping the project going :)