search

arbyste / jp-mining-note

Temporary bugfix fork for JPMN
MIT License
31 stars 1 forks source link

Changing regexMatch to block form #4

Closed ppsqkk closed 6 months ago

ppsqkk commented 6 months ago

Fixes #3, also fixes manual selection of the primary definition. But, I did not fix the jpmn-min-freq handlebar because it's supposedly deprecated.

The problem is that regexMatch no longer works in the form {{regexMatch regex [flags] [text-to-modify]...}}. Instead, it only works in the form {{#regexMatch regex [flags]}}text-to-modify{{/regexMatch}}. Maybe an issue should be raised in Yomitan?

arbyste commented 6 months ago

Thanks for this! The only change I made was updating the frequency sort version to match Marv's.

I'm not super familiar with handlebars, so I've asked the Yomitan devs to take a quick look at your regexMatch change. When they say it looks sensible, I'll merge it in.

arbyste commented 6 months ago

Also decided to use this opportunity to update the ignored dictionaries for frequency sorting

arbyste commented 6 months ago

It looks like this is being fixed here: https://github.com/themoeway/yomitan/pull/535

I'll merge it in for now, since it might take a while for the changes to get into the stable version of Yomitan, though we may need to revert the regexMatch change later