search

arc-archive / api-navigation

⛔️ DEPRECATED This component is being deprecated. Use `@api-components/amf-components` instead.
0 stars 1 forks source link

Fix endpoint expansion when an operation is opened programmatically #27

Closed deiteris closed 3 years ago

deiteris commented 3 years ago

@TwoPlusTwoOne, @carowright, @jarrodek, could you review this one please?

deiteris commented 3 years ago

@TwoPlusTwoOne I've added the test case, you can verify that it works by commenting out my piece of code.

Just for history and to clarify the issue a bit, here's the gif that shows what it looks like. The endpoint method is being set by apinav.selected = "#id", but the parent is not being expanded to show the selection. For some reason, this doesn't happen with "overview" sections. gh_issue

deiteris commented 3 years ago

Done. I also renamed the fix commit and changed the title of the PR so it is clear. But it looks like this branch is outdated. Should I re-create the PR for the main branch?

twoplustwoone commented 3 years ago

Yes that would be best, thank you very much. I hadn't seen the base branch