search

arc-bath / template_jupyter

Template and tutorial for the jupyter based build system to produce ARC training material.
https://arc-bath.github.io/template_jupyter/
0 stars 2 forks source link

Add the refernces environment #5

Closed arm61 closed 5 years ago

arm61 commented 5 years ago

Added the references environment to the build system branch

JDBetteridge commented 5 years ago

Try fetching upstream/master and the build should pass (you appear to be missing a file from the tools directory)

arm61 commented 5 years ago

hang on, @james-grant1 told me to building stuff onto build-system and not master?

JDBetteridge commented 5 years ago

Is that what he's called the development branch???

arm61 commented 5 years ago

....yes I think so?

JDBetteridge commented 5 years ago

Okay, I'll do another PR

arm61 commented 5 years ago

cheers bae

james-grant1 commented 5 years ago

I may need to look into this ... The build_system seems to be missing the index_footer file. I'm just adding and pushing ...

james-grant1 commented 5 years ago

Right it's now passing, my bad. @JDBetteridge is the additional mention in style_template.tpl necessary. Didn't do this with the pin and write, if so will need to add these too ...

arm61 commented 5 years ago

This not getting pulled then?

james-grant1 commented 5 years ago

Turns out if you change the name of a branch, github loses track of it and automatically closes the pull requests, which is a bit of a shame. I am adding the references manually, as well as adding an example to the tutorial, these will be appearing shortly.