search

arc-design / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
695 stars 55 forks source link

google-chrome 69: private sessions looks almost the same than standard #142

Open aslafy-z opened 5 years ago

aslafy-z commented 5 years ago

Details

2018-10-09-151304_1920x1080_scrot

WORKAROUND: See https://github.com/NicoHood/arc-theme/issues/142#issuecomment-428276466

jnsh commented 5 years ago

Do you actually have some idea of how to make this better?

The Arc-Dark(er) is dark by design and that can't really be changed, and the chrome/chromium private window is dark by google's design. Even if it was possible to change the private window theming in the gtk3 theme (it may or may not be, I'm really not sure), I can't think of any sensible way to improve the design.

aslafy-z commented 5 years ago

I don't, really

WORKAROUND: Use the old 'Hybrid' UI https://askubuntu.com/questions/1072234/how-to-get-back-my-previous-omnibox-in-google-chrome-69-or-chromium-69

Thanks @jnsh https://github.com/NicoHood/arc-theme/issues/141#issuecomment-428250906

jnsh commented 5 years ago

Is there something different with the "Hybrid UI" that makes private browsing windows more distinguishable?

The thing is, that unless you have some specific suggestions, I don't really see much that could be done to this. I think the same issue affects every other dark theme as well, including Adwaita-Dark, and every other browser that chooses to use the dark theme with the private/incognito windows, e.g. Firefox.

It'd be better bug the browser developers about this, and now that there's at least one "mainstream" OS, that provides a dark theme (Mac OS), the issue might get some more attention as well.

aslafy-z commented 5 years ago

Hybrid UI:

2018-10-09-204243_1920x1080_scrot

There is a little icon that made the difference, I assume that google-chrome 69 ditched it since it does not appear when I switch back to default UI and Bundled theme instead of GTK+ one. The only thing that changes is the color or the window

Default UI Classic Theme:

2018-10-09-204749_1920x1080_scrot

jnsh commented 5 years ago

Yes, apparently the incognito icon was moved to the left next to the address bar.

One thing you could do, is force chrome to use the default light Arc theme variant with GTK_THEME environment variable documented in this page, although I understand that may not be preferable solution at all.