search

arc-design / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
696 stars 55 forks source link

Dialog boxes have tiny titlebar with no title text (Cinnamon DE) #152

Closed Sadi58 closed 5 years ago

Sadi58 commented 5 years ago

The title bar of dialog boxes in many apps is both very narrow and does not show the title text. Linux Mint's default theme Mint-Y is based on the original Arc theme, and naturally it has the same issue. But some other themes like Numix and Greybird don't have this issue. A quick list Firefox: File Open & Save both Google Chrome: File Open & Save both LibreOffice: File Open & Save both medit: File Open & Save both GIMP: File Open & Save both OK. Thunderbird: Message Open & Save both, but not Preferences Xed: File Open is OK but not File Save (screenshots below)

selection_2018-10-16-00 21 29

selection_2018-10-16-00 20 27

Distribution: Linux Mint 19 Base distribution: Ubuntu 18.04 Desktop environment: Cinnamon 3.8.9 Arc version/commit: 20180716-1+201810081731 GTK+ 3 version: 3.22.30 Murrine engine version: 0.98.2 gnome-themes-extras version: 3.28 Installation method: package

jnsh commented 5 years ago

As I said on the comments of another issue, I can't reproduce this in gnome-shell, so I'd imagine this is Cinnamon specific issue.

Unfortunately I don't think there are anyone actively maintaining the Arc cinnamon theme at the moment, so quite frankly this doesn't seem likely to get fixed here any time soon. If the same bug is present with Linux Mint's default theme, you may have better report this upstream to Mint developers, since they are developing the Cinnamon shell as well, and should have greater incentive for fixing the issue.

If they can figure out a fix, it can probably be backported to Arc theme with relative ease.

Sadi58 commented 5 years ago

Thanks, yes, this is a good idea!

NicoHood commented 5 years ago

The mint devs forked arc theme, so they might be able to help you out with this. I do not understand why they dont contribute all the stuff back here and we are not working on color variants yet. Its the same torture like ubuntu/distribution forks.

Sadi58 commented 5 years ago

I will definitely let you know if they find a fix for this!

Unfortunately, this is a big problem in Linux world, too much duplication, framentation, lack of coordination, and eventually a lot of inefficiency. I'm not sure if this is the price of freedom that we have to pay...

For instance, they have a couple of things missing from the current Arc theme because they forked the original one - e.g. file manager tab being highlighted when you drag an item to it from another tab.

Sadi58 commented 5 years ago

I've just noticed another problem with those dialog boxes: some missing widgets as seen in the screenshot below - followed by another screenshot from the theme Mint-Y-Yltra-Light displaying those missing widgets like Mint-Y it's based on. selection_2018-10-21-18 03 10 selection_2018-10-21-18 05 45

Booteille commented 5 years ago

I have a similar issue with the latest version of arc-theme downloaded on the ppa fossfreedom.

When I choose Arc-Dark (or any Arc variant) as my theme for controls, some buttons (like checkbox or close/minimize buttons of firefox) are hidden. They still work but I can't see them. If I choose any other theme (like Mint-Y as an exemple), buttons show again.

Firefox with Arc-Dark : firefox_buttons_missing_arcdark Firefox with Mint-Y Dark : firefox_buttons_minty Checkbox with Arc-Dark : checkbox_missing_arcdark Checkbox with Mint-Y Dark : checkbox_minty

I am on Linux Mint 19, using cinnamon 3.8.8. I am using Firefox Developper Edition 64.0b2. The window control buttons are presents on other programs except some, like the archive manager (file-roller 3.28.0-1ubuntu1).

Sadi58 commented 5 years ago

It's interesting, I don't have the problem reported above by @Booteille with Firefox (62.0.3 64-bit) window control buttons, but they are invisible in Archive Manager (and a couple of other gnome apps with the new header bar I guess).

chewi commented 5 years ago

There was briefly a problem between 550065724bb50cff953a067ce094fb63e4f5a7f6 and 5444ac751f15ddcc7532ca06243def7c948ae6c1 that would have caused something like this and that's probably what the last comment refers to but this issue was opened before that.

Booteille commented 5 years ago

My issue seems to be solved with the last update. (20181023-1+201810240002~ubuntu18.04.1)

Sadi58 commented 5 years ago

Yes, I can also confirm that the issue of missing widgets (as seen in the LibreOffice Writer Table Properties screenshot above) and missing window control buttons (e.g. in Archive Manager) has now been resolved.

Now only the issue of too small titlebar for some dialog boxes (missing title text) remains.

jnsh commented 5 years ago

Please keep this issue only about the titlebar on Cinnamon. @Sadi58 have you reported the issue to Mint /Cinnamon developers as I suggested earlier?

Sadi58 commented 5 years ago

@jnsh Yes, I reported this 6 days ago. No response yet. I'll update...

NicoHood commented 5 years ago

Can we close this now?

Sadi58 commented 5 years ago

It's not resolved. It's up to you to tag it "won't fix" and close. If I were in your shoes, I would keep it open until possibly a fix comes from Mint-Y team.

NicoHood commented 5 years ago

The mint team does not care. They will not open any PR to fix things back here. You have to trigger them and ask if they can assist with help. I dont see any other solution. Otherwise we might consider to drop cinnamon support completely.

Sadi58 commented 5 years ago

They seem quite active here: https://github.com/linuxmint/mint-themes Let's give them a little time...

smurphos commented 5 years ago

This just needs a little tweak to the metacity-theme-3.xml for Cinnamon. I'm pretty sure the same bug is in Mate as-well - metacity-theme-2.xml for that one. Does any DE still use metacity-theme-1?

I'll double check Mate and make a fixing PR in the next day or two.

@NicoHood - if you'd like some help updating the Cinnamon.css to bring it in line for Cinnamon 4.x please let me know. I've got a few other jobs on my to do list first so it might be a week or so until I get time to get to it.

For clarity I'm not part of Mint - just a user and contributor. Also a contributor to oomox, Materia and Adapta.

fossfreedom commented 5 years ago

Yes please. We are definitely looking for people who are willing to finesse their favourite desktop environment

On Mon, 3 Dec 2018, 06:33 Steve M <notifications@github.com wrote:

This just needs a little tweak to the metacity-theme-3.xml for Cinnamon. I'm pretty sure the same bug is in Mate as-well - metacity-theme-2.xml for that one. Does any DE still use metacity-theme-1?

I'll double check Mate and make a fixing PR in the next day or two.

@NicoHood https://github.com/NicoHood - if you'd like some help updating the Cinnamon.css to bring it in line for Cinnamon 4.x please let me know. I've got a few other jobs on my to do list first so it might be a week or so until I get time to get to it.

For clarity I'm not part of Mint - just a user and contributor. Also a contributor to oomox, Materia and Adapta.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NicoHood/arc-theme/issues/152#issuecomment-443603092, or mute the thread https://github.com/notifications/unsubscribe-auth/AA8zkPr66Ax2lYCc3Yi2lEDW_VvHUqsVks5u1MWhgaJpZM4XdK7Y .

smurphos commented 5 years ago

@Sadi58

Can you check your Window Manager settings. Specifically do you have 'Attach dialogs to their parent window' checked - that causes dialog windows to have no title in the titlebar with Arc as per the original design of the Metacity theme.

screenshot-window-2018-12-09-104231

Without it checked you get a smaller titlebar with a title with no close buttons in Arc. The PR I've just submitted gives them a normal size titlebar with a close button.

Sadi58 commented 5 years ago

@smurphos You're right! Thanks! I've unchecked it now and I even have a close button in GIMP unlike others ;-)

smurphos commented 5 years ago

Cool - Now what I'm not sure of is whether the lack of a title for Attached dialogs (rather than unattached modal dialogs) on Arc and thus Mint-Y is a definitely a design decision or not. Other themes do have a title on attached windows. I'll need to play some spot the difference between Arc and some other themes as the obvious fix in Arc didn't work...

JosephMcc commented 5 years ago

Hey guys. I stumbled across this completely by accident looking for something else. There seems to be some bad feelings toward Mint devs for not contributing back to you guys. Since I do nearly all maintenance on the mint themes that would be me you're pointing the finger at :)

Unfortunately the problem here really comes down to time. I have a limited amount of time to work on this and trying to follow and help out even more projects just isn't in the cards. There is also the issue that the longer these two themes exist, the more they deviate from one another and the less relevant changes become to each other. Even the basic color schemes used in the two themes no longer match and this will continue to grow worse. I know you want to consider yourselves some kind of upstream from us but at this point I don't know that it's really very relevant. It has nothing to do with lack of caring.

Sadi58 commented 5 years ago

BTW, the issue is gone in Mint-Y theme now (with "Attach dialogs to their parent window" is checked in Settings/Windows). Maybe you can figure out which change made this possible...

smurphos commented 5 years ago

BTW, the issue is gone in Mint-Y theme now (with "Attach dialogs to their parent window" is checked in Settings/Windows). Maybe you can figure out which change made this possible...

There's nothing to figure out - I submitted the PR to fix the issue in Mint-Y (which @JosephMcc reviewed IIRC) and the equivalent PR here #174 is waiting to be merged subject to @NicoHood or @fossfreedom deciding it they want they want the other window decoration button modifications in the PR included or not.

NicoHood commented 5 years ago

@fossfreedom We should just merge the PR, what do you think?

fossfreedom commented 5 years ago

Agree. Merge and then everyone who has an interest can test further.