arc-design / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
696 stars 55 forks source link

Incorrect authentication modal title color on Arc-dark #156

Open jasl opened 5 years ago

jasl commented 5 years ago

screenshot-20181023162608-2204x1604

Details

jnsh commented 5 years ago

I can't reproduce the issue.

It also seems that the modal dialog shadows are all messed up on your screenshot, so there appears to be something very wrong with the shell theme. Could you test whether you can still reproduce the issue if you build and install the theme manually?

@fossfreedom Have you checked that there's nothing wrong with the ubuntu packages lately? There's been a few reports from people using debian/ubuntu where the theme seems completely messed up, i.e. #148 #123

jasl commented 5 years ago

I'll try to build the theme tomorrow.

For the screenshot, Settings -> Details -> Users, then click unlock

jnsh commented 5 years ago

For the screenshot, Settings -> Details -> Users, then click unlock

That is how I tested this issue.

What I meant by being unable to reproduce it, is that for me the title text is using the same color as the rest of the texts on that dialog.

jasl commented 5 years ago

Sorry I'm busy on weekends, I've tested the latest daily build (on Ubuntu 18.04, arc-theme fetch from PPA) in virtual machine (Hyper V), it looks great and no issue found.

Maybe it relates to GTK or Xorg, My laptop (which I found this issue) is a Dell Precision 7530 with 8 gen Core CPU and Quadro P3200, 4K display (200% scale), I tried Nvidia & open source driver and Intel iGPU, all have this issue.

jasl commented 5 years ago

I tried again on my Intel Skull Canyon NUC (Ubuntu 18.10), found the same issue

fossfreedom commented 5 years ago

Can you try the GNOME Xorg session as per this comment https://github.com/NicoHood/arc-theme/issues/49#issuecomment-434067421 - just wondering if its Ubuntu's CSS that is causing issues like this.

jasl commented 5 years ago

@fossfreedom You're right, It looks fine on vanilla Gnome

screenshot-20181031204704-2064x1508

fossfreedom commented 5 years ago

grrrr ... I've no idea how Ubuntu's session is overriding stuff ... but it is annoying!

Thanks for the confirmation @jasl

If someone who runs gnome-shell on Ubuntu's default session finds out the answer please shout!

jasiralavi commented 5 years ago

I have the same issue. It shows these broken shadows around the volume and notification popups also. screenshot from 2018-11-15 14-12-29

It happens only on Arc-dark theme. If i switch to Arc theme the shadow issues goes away.

NicoHood commented 5 years ago

We should open a bug at ubuntu. They did not design a proper theme, they crippled their OS in such a way that other themes break. That is just bad practise and confusing for users, time consuming for developers dealing with bugs they cannot solve. Over and over again.

elmagio commented 5 years ago

Is there anyway to simply remove Ubuntu's custom CSS for their session, if that's what's causing the issue? That would probably break their Yaru theme, but in desperate times...

b-reich commented 5 years ago

@NicoHood did you open a bug report?

NicoHood commented 5 years ago

Nope, no time. Please go ahead.

b-reich commented 5 years ago

I found some time and reported the bug https://bugs.launchpad.net/ubuntu/+source/gnome-themes-extra/+bug/1813465

almk-dev commented 5 years ago

Part of the issue is that it is difficult to reproduce. I had the exact same issue as above, on both my desktop and my laptop (with nearly identical setups). On both, after flipping between Arc and Arc-Dark for the shell setting in gnome-tweaks, and going in and out of the gnome activities screen a few times, the issue resolved itself. However, it reappears on reboot without fail.

It seems unlikely that it is due to a user modification because of the (seemingly) arbitrary nature of the bug.

spiritedsnowcat commented 5 years ago

Hi all, I found a fix for this for those running Ubuntu 18 and 19. Run the following command:

sudo apt install vanilla-gnome-default-settings

Then, logout and log back in using "GNOME on Xorg" for the session type (cog wheel menu). Cheers.