search

arc-design / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
696 stars 55 forks source link

Change the color of seperators in context menus #158

Closed cynecx closed 5 years ago

cynecx commented 5 years ago

Before:

before

After:

after

NicoHood commented 5 years ago

Does this only happen with the dark theme? Because with the darker theme it look good to me.

jnsh commented 5 years ago

First, the original design by @horst3180 uses light separator for dark menus, and IMHO there would have to be a very good reason to change that.

Second, any such changes would have be applied to all themes, i.e. all gtk3 theme versions, gtk2 theme, gnome-shell theme, etc.

NicoHood commented 5 years ago

I like the idea.

fossfreedom commented 5 years ago

Agreed - this should be merged only when similar changes are made for gtk2 gnome shell etc otherwise we get a inconsistent approach.

qwertychouskie commented 5 years ago

@cynecx What's the status on this? Can you implement the change for GTK2 also so it can be merged?

fossfreedom commented 5 years ago

This PR diverts from the original arc design. I don't see a consensus here and it needs more work anyway to make it GTK+2 compliant. So I'll close this for now.