search

arc-design / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
696 stars 55 forks source link

Dynamic transparency for GNOME panel (top bar) #173

Closed drakkar1969 closed 5 years ago

drakkar1969 commented 5 years ago

Would there be any interest in implementing dynamic transparency for the GNOME panel (like the Adwaita theme does in newer versions of gnome shell)?

Screenshots (with modded Arc-Dark shell theme):

normal max

It would only require a couple of changes in the gnome shell css:

Need to change this:

#panel {
  font-weight: bold;
  height: 2.1em;
  min-height: 27px;
  background-gradient-direction: none;
  background-color: transparent;
  border-bottom-width: 0;
  border-image: url("common-assets/panel/panel.svg") 1 1 1 1; }

to:

#panel {
  font-weight: bold;
  height: 2.1em;
  min-height: 27px;
  background-gradient-direction: none;
  background-color: transparent;
  border-bottom-width: 0;
  border-image: none; }
#panel.solid {
  border-image: url("common-assets/panel/panel.svg") 1 1 1 1; }

And this:

#panel:overview {
  border-image: url("common-assets/panel/panel-overview.svg") 1 1 1 1; }

to:

#panel:overview {
  border-image: none; }

I can make a PR if helpful

Details

fossfreedom commented 5 years ago

Is this a permanent transparency or is there a configurable option in gnome shell to turn transparency on and off?

If its user configurable I would support including this in arc and would welcome a PR.

On Sat, 8 Dec 2018, 13:19 drakkar1969 <notifications@github.com wrote:

Would there be any interest in implementing dynamic transparency for the GNOME panel (like the Adwaita theme does in newer versions of gnome shell)?

Screenshots (with modded Arc-Dark shell theme):

[image: normal] https://user-images.githubusercontent.com/18715287/49686287-9db95a80-faf2-11e8-8a44-3b69e3152636.png [image: max] https://user-images.githubusercontent.com/18715287/49686288-a1e57800-faf2-11e8-9b56-26000431ac80.png

It would only require a couple of changes in the gnome shell css:

Need to change this:

panel {

font-weight: bold; height: 2.1em; min-height: 27px; background-gradient-direction: none; background-color: transparent; border-bottom-width: 0; border-image: url("common-assets/panel/panel.svg") 1 1 1 1; }

to:

panel {

font-weight: bold; height: 2.1em; min-height: 27px; background-gradient-direction: none; background-color: transparent; border-bottom-width: 0; border-image: none; }

panel.solid {

border-image: url("common-assets/panel/panel.svg") 1 1 1 1; }

And this:

panel:overview {

border-image: url("common-assets/panel/panel-overview.svg") 1 1 1 1; }

to:

panel:overview {

border-image: none; }

I can make a PR if helpful Details

  • Distribution (with version): Arch Linux
  • Desktop environment (with version): GNOME 3.30
  • Arc version/commit (don't put "latest"): 20181022
  • GTK+ 3 version: 3.24.1
    • Murrine engine version: 0.98.2
    • gnome-themes-extras version: n/a
  • Installation method (package or source): Arch AUR package

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NicoHood/arc-theme/issues/173, or mute the thread https://github.com/notifications/unsubscribe-auth/AA8zkMWXVbyUYlKknCjLREb6kTx4827Dks5u27xIgaJpZM4ZJolc .

drakkar1969 commented 5 years ago

it appears to be permanent, i.e. there is no setting to turn on and off

Just to clarify, the transparency is dynamic, i.e. panel is transparent when there are no maximized windows and no windows touching the panel. If a window is maximized or otherwise touches the panel, the panel dynamically turns opaque (and viceversa)

NicoHood commented 5 years ago

I like the idea, and I think there was some post about that before!?

Could you please open a PR for that change?

drakkar1969 commented 5 years ago

Ok, opened a pull request: #175

dominichayesferen commented 5 years ago

@drakkar1969 @NicoHood Too bad that it looks like GNOME is now REMOVING panel translucency for non-maximised windows by the sounds of it... https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/376

NicoHood commented 5 years ago

I've seen this too. Do we need to change our theme or can we leave it as is?

fossfreedom commented 5 years ago

@NicoHood we should revert - https://github.com/NicoHood/arc-theme/pull/193