search

arc-design / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
695 stars 55 forks source link

Add full shadows to GNOME shell panel button dropdown menus #246

Closed drakkar1969 closed 4 years ago

drakkar1969 commented 5 years ago

Courtesy of the Plata theme, found a solution to render proper drop shadow around gnome shell panel button dropdown menus. Testing welcome ....

shadow

fossfreedom commented 5 years ago

Hi,

I (and I am sure nico is as well) have been impressed with the quantity and quality of your gnome-shell contributions.

Many many thanks. Would you like contributor access rights to continue your good work?

As before you would submit PRs via a branch or your own fork. But you can also accept immediately. Also you will have the ability of to open and close issues etc.. let me know if your are interested.

drakkar1969 commented 5 years ago

Hi, thanks for the kind words :). Sure I'd be interested, and would definitely use the new access rights carefully ...

fossfreedom commented 5 years ago

Excellent!

@NicoHood assuming you concur - please add drakkar1969 with collaborator rights. TIA

NicoHood commented 5 years ago

I have no problem, I suggested the same to @jnsh. It would be good if all changes are encapsulated in a PR, so we can track changes better and tag them via github. A Quick review from another team member would be good, so we dont overlook something that might break on another side.

drakkar1969 commented 5 years ago

Makes sense to me

NicoHood commented 5 years ago

See discussion here: https://github.com/NicoHood/arc-theme/commit/a6cf4045f6f59fae91831401f9b3bbcfd72d0916

Lets wait for that first.

drakkar1969 commented 5 years ago

Ok, saw the discussion, can see why you would want to wait :)