search

arc-design / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
696 stars 55 forks source link

Difference in xfce setting headline color #25

Open NicoHood opened 6 years ago

NicoHood commented 6 years ago

I found out that the darker colors are not applied to arc-darker: screenshot from 2018-01-08 20-13-49 screenshot from 2018-01-08 20-14-37

NicoHood commented 6 years ago

Imported answer from @fossfreedom https://github.com/NicoHood/arc-theme/pull/15#issuecomment-356432190

@NicoHood I'm not an XFCE user so I can't really say if the following change works in general so please can you test?

It appears that that appearance window is a GTK-2 window - so gtk-2 stuff is in common/gtk-2.0

so the text color/fg color between the arc (gtkrc) arc-darker (gtkrc-darker) and arc-dark (gtkrc-dark) are different deliberately at the moment.

ubuntu budgie - new development artful running - oracle vm virtualbox_030

if you change the fields shown in the picture to be the same as Arc (gtkrc) then the text colour is the same - if you feel this looks better, push a commit on that file

NicoHood commented 6 years ago

Cant we use variables for this? Otherwise every change in colors will need manual change of the gtk2 files. And gtk2 will be supported for some long time I guess.

fossfreedom commented 6 years ago

I'm willing to be wrong ... but I think variables only work for SASS - the gtk-2 stuff isnt SASS based.

NicoHood commented 6 years ago

I saw some kind of variables here, I do not know where they come from!? https://github.com/NicoHood/arc-theme/blob/master/common/gtk-2.0/panel.rc#L7

fossfreedom commented 6 years ago

ah - "@selected_bg_color" corresponds to the color-scheme name in gtkrc or gtkrc-dark or gtkrc-darker

i.e.

gtk-color-scheme = "selected_bg_color: #5294e2"

so the theme sees "@selected_bg_color" and looks up the color scheme name and uses the value "#5294e2" So - "@selected_bg_color" could be regarded as a variable - its just defined in each gtkrc file.