arc-design / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
696 stars 55 forks source link

GtkInfoBar doesn't respect message type #259

Closed shelacek closed 5 years ago

shelacek commented 5 years ago

Hello, all infobar types have same background color ($selected_bg_color): https://github.com/NicoHood/arc-theme/blob/2c45d9e4b4a120201dc029a10937058a2e9e094b/common/gtk-3.0/3.20/sass/_common.scss#L2826-L2833

infobar-colors

Is there any reason for this? Can't we use colors like $warning_color and $error_color?

Details

fossfreedom commented 5 years ago

reasonable request.

change would be something like the following:

infobar {
  border-style: none;
  &.info { background-color: $success_color; }
  &.question { background-color: $suggested_color; }
  &.warning { background-color: $warning_color; }
  &.error { background-color: $error_color; }
  &.info,
  &.question,
  &.warning,
  &.error {
    color: $selected_fg_color;
    caret-color: currentColor;
    button { @extend %selected-button }
    selection {
      color: $selected_bg_color;
      background-color: $selected_fg_color;
    }
    *:link { @extend %link_selected; }
  }
}