arc-design / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
695 stars 55 forks source link

Arc-Darker - Evolution mail having issues with Papirus icons #283

Open maboleth opened 4 years ago

maboleth commented 4 years ago

I love your theme guys, it's the only one I use on my Arch!

However, I have an issue with Arc Darker theme, the way it handles Evolution mail in Gnome and Papirus icons.

Basically it comes to this. If Arc Darker is used together with Papirus icons, Evolution icons will either be invisible black or invisible white somewhere, depending on the background. Something in the window will be invisible.

Why? Because Arc Darker colors the sub menu (New Mail / Send Receive / Reply) black, while leaving other windows white. If I use Papirus dark, the icons in the menu above will be visible, but the one in the inbox will not (white). And vice versa - if original Papirus or Papirus light is used, icons in the inbox are visible, but the one in the menu are invisible (black).

How to fix? I think it's rather simple - make the sub menu the same color as the window (white) for Arc-Darker. That way Papirus could be used nicely, depending on whether the theme is black, semi-black or white.

Please note that guys handling Papirus icons cannot do anything about this. They can use either black or white icon sets.

I think Arc-Darker should make the change and still be very much in-line with the rest of the theme (File/Edit/View menu will remain black, as the rest of the theme).

Thanks.

jnsh commented 4 years ago

I think the Evolution application itself is at fault here, for not using symbolic icons for the toolbar like every other GNOME application does. I suppose you should bug its developers about this.

Changing the overall theme style because of one application is misbehaving with a certain icon theme seems unreasonable. Sometimes you could add an application specific styling, but that didn't seem possible with Evolution.

The gtk theme could enforce symbolic icons for every image-button, but that could technically result in issues with some applications, and I wouldn't do it unless that was something that default gtk themes did as well. Especially if it was only to work around single misbehaving application.

However you can inject the CSS styling workaround yourself by adding something like the following to your ~/.config/gtk-3.0/gtk.css:

.flat.image-button {-gtk-icon-style: symbolic;}