search

arc-design / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
696 stars 55 forks source link

Use non-deprecated options for inkscape #288

Closed sandip4n closed 4 years ago

sandip4n commented 4 years ago

The --export-png option has been deprecated in recent versions of inkscape. Instead, the same functionality must be achieved by using the --export-type and the --export-file options together.

jnsh commented 4 years ago

This breaks build with inkscape 0.92, which is currently the stable release. I'm quite sure it'll still take many months before they release 1.0 (which changed the command line arguments) as stable.

I worked around this with https://github.com/jnsh/arc-theme/commit/d7bac2e407696ced7e7a281cb5d2cb8d3228f973

sandip4n commented 4 years ago

@jnsh Your patch definitely has better backward compatibility. Can you please open a pull request for that? I am closing this one.

jnsh commented 4 years ago

@sandip4n Sorry, I'm maintaining my own fork, and don't have time or interest to additionally work for this repo (I'd rather recommend anyone to use my fork, since it's actually being maintained).

It shouldn't be too big of a task for maintainers here to rebase the aforementioned commit for this repo though.