search

arc-design / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
695 stars 55 forks source link

make fails due to inkscape cmd line change #291

Open shoeper opened 4 years ago

shoeper commented 4 years ago

Details

See bottom for interesting part.

~/D/arc-theme (master=) ./autogen.sh --prefix=/usr
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I m4
autoreconf: configure.ac: tracing
autoreconf: configure.ac: not using Libtool
autoreconf: running: /usr/bin/autoconf --force
autoreconf: configure.ac: not using Autoheader
autoreconf: running: automake --add-missing --copy --force-missing
autoreconf: Leaving directory `.'
configure: loading site script /usr/share/config.site
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether ln -s works... yes
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
Building for GTK3 3.20
checking for gnome-shell... yes
Building for gnome-shell 3.34
checking for rendersvg... no
configure: WARNING: rendersvg not found, using inkscape instead
checking for inkscape... /usr/bin/inkscape
checking for optipng... /usr/bin/optipng
checking for sassc... /usr/bin/sassc
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating common/gtk-2.0/Makefile
config.status: creating common/gtk-3.0/Makefile
config.status: creating common/gtk-3.0/3.18/Makefile
config.status: creating common/gtk-3.0/3.20/Makefile
config.status: creating common/xfwm4/Makefile
config.status: creating common/Makefile
config.status: creating extra/Makefile
config.status: creating Makefile
~/D/arc-theme (master=) make
Making all in common
make[1]: Entering directory '/home/sven/Downloads/arc-theme/common'
Making all in gtk-2.0
make[2]: Entering directory '/home/sven/Downloads/arc-theme/common/gtk-2.0'
/usr/bin/inkscape --export-id-only --export-png="light/assets/arrow-down.png" --export-id="arrow-down" --export-dpi=96 "light/assets.svg" >/dev/null
Unknown option --export-png=light/assets/arrow-down.png
make[2]: *** [Makefile:731: light/assets/arrow-down.png] Error 1
make[2]: Leaving directory '/home/sven/Downloads/arc-theme/common/gtk-2.0'
make[1]: *** [Makefile:435: all-recursive] Error 1
make[1]: Leaving directory '/home/sven/Downloads/arc-theme/common'
make: *** [Makefile:360: all-recursive] Error 1

From readme I see that my Gnome version is higher than the given range GNOME Shell 3.18 - 3.32. When disabling gtk2 it fails for gtk3 with same issue and so on.

Inkscape version is (inkscape --version) Inkscape 1.0beta2 (unknown). It has been installed from Fedora 31 repo. rendersvg seems not to be available.

Looking at https://gitlab.com/inkscape/inkscape/issues/516 the option has been changed and now is named export-file

Affected files:

~/D/arc-theme (master=) fgrep "export-png" * -r
common/gtk-3.0/common.am:   $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(basename $(notdir $@))" --export-dpi=96 "$<" >/dev/null
common/gtk-3.0/common.am:   $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(patsubst %@2,%,$(basename $(notdir $@)))" --export-dpi=192 "$<" >/dev/null
common/gtk-3.0/3.18/Makefile.in:@RENDERSVG_FALSE@   $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(basename $(notdir $@))" --export-dpi=96 "$<" >/dev/null
common/gtk-3.0/3.18/Makefile.in:@RENDERSVG_FALSE@   $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(patsubst %@2,%,$(basename $(notdir $@)))" --export-dpi=192 "$<" >/dev/null
common/gtk-3.0/3.18/Makefile:   $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(basename $(notdir $@))" --export-dpi=96 "$<" >/dev/null
common/gtk-3.0/3.18/Makefile:   $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(patsubst %@2,%,$(basename $(notdir $@)))" --export-dpi=192 "$<" >/dev/null
common/gtk-3.0/3.20/Makefile.in:@RENDERSVG_FALSE@   $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(basename $(notdir $@))" --export-dpi=96 "$<" >/dev/null
common/gtk-3.0/3.20/Makefile.in:@RENDERSVG_FALSE@   $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(patsubst %@2,%,$(basename $(notdir $@)))" --export-dpi=192 "$<" >/dev/null
common/gtk-3.0/3.20/Makefile:   $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(basename $(notdir $@))" --export-dpi=96 "$<" >/dev/null
common/gtk-3.0/3.20/Makefile:   $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(patsubst %@2,%,$(basename $(notdir $@)))" --export-dpi=192 "$<" >/dev/null
common/gtk-2.0/Makefile.in:@RENDERSVG_FALSE@    $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(basename $(notdir $@))" --export-dpi=$(if $(filter $(OPTION_GTK2_HIDPI),true),192,96) "$<" >/dev/null
common/gtk-2.0/Makefile.am: $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(basename $(notdir $@))" --export-dpi=$(if $(filter $(OPTION_GTK2_HIDPI),true),192,96) "$<" >/dev/null
common/gtk-2.0/Makefile:    $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(basename $(notdir $@))" --export-dpi=$(if $(filter $(OPTION_GTK2_HIDPI),true),192,96) "$<" >/dev/null
common/xfwm4/Makefile.in:@RENDERSVG_FALSE@  $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(basename $(notdir $@))" --export-dpi=$(if $(filter $(OPTION_GTK2_HIDPI),true),192,96) "$<" >/dev/null
common/xfwm4/Makefile.am:   $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(basename $(notdir $@))" --export-dpi=$(if $(filter $(OPTION_GTK2_HIDPI),true),192,96) "$<" >/dev/null
common/xfwm4/Makefile:  $(INKSCAPE) --export-id-only --export-png="$@" --export-id="$(basename $(notdir $@))" --export-dpi=$(if $(filter $(OPTION_GTK2_HIDPI),true),192,96) "$<" >/dev/null
shoeper commented 4 years ago

Would be good if https://github.com/jnsh/arc-theme/commit/d7bac2e407696ced7e7a281cb5d2cb8d3228f973 could be merged.

jnsh commented 4 years ago

Would be good if jnsh/arc-theme@d7bac2e could be merged.

I'm quite certain that's not going to happen. This project seems to be effectively abandonded, and frankly, has never been properly maintained anyway.

Even if that wasn't the case, if you're building the theme yourself, you should be far better off switching over to jnsh/arc-theme. I've fixed numerous bugs that persist in this repo (and even the original arc-theme repo), among other improvements. Also I am actually maintaining the theme and will look at fixing any issues you may find.