arc-design / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
696 stars 55 forks source link

menuitem color mate global menu washed out #32

Open mschoones opened 6 years ago

mschoones commented 6 years ago

This was originally posted on the repo of horst3180. It still exist for the latest version from this repo.

Ubuntu Mate: 17.10 mate global menu

Installed arc theme from your repo, installed version: arc-theme (20171105-0+201712202146~ubuntu17.10.1)

The color of the menuitem in the menu dropdown is washed out. The arrow next to the label has the correct color, but the label itself does not.

Please make the label itself the same dark color. Or let me know what to change in the gtk.css file. 32144650-547ffeca-bcbc-11e7-9498-a603cadd28e9

NicoHood commented 6 years ago

You might want to try the latest master (release on 14th jan) which makes colors for the light arc variant darker.

Otherwise its somewhere here: https://github.com/NicoHood/arc-theme/tree/master/common/gtk-3.0/3.20/sass

Please search for a matching entry and try to add a new color for testing. I am also not yet an gtk pro, so i have to search also.

mschoones commented 6 years ago

Ok, I will look for a fix using your input. Might not get around to it until the weekend. Will keep you updated. Thank you.

waterlubber commented 6 years ago

I'm using the latest package from the fossfreedom PPA (which appears to be the latest master). I still have washed out menus, however (for example, in Hexchat, LibreOffice, and in a few other applications)

Screenshot: https://i.imgur.com/xAvjtM9.png

waterlubber commented 6 years ago

Where would these files be in the installed /usr/share/themes directory? I'm having these washed out menus only in gtk-2 applications, as far as I can tell (HexChat, LibreOffice, Audacity), so I don't see how editing the gtk-3 files would help. It actually looks like the disabled (typically "grayed out") menu items and ENABLED ones are switched -- the enabled ones are very hard to read.

fossfreedom commented 6 years ago

GTK+2 based changes are made in this area of the code-base https://github.com/NicoHood/arc-theme/tree/master/common/gtk-2.0

So you git clone the repository.

Make your changes in the .rc files then use the instructions in the README to compile and install the theme - it will install under /usr/share/themes/{Arc/Arc-Darker/Arc-Dark}

waterlubber commented 6 years ago

Is compilation necessary? I've been having a hard time getting sassc to work...

anyway, I managed to fix the problem by reversing menu foreground and background colors using gtk-theme-config. (That was the actual problem, most likely, MATE was displaying Arc's menu background colors and Arc-Dark's font colors)

pedrohasantiago commented 6 years ago

Hey, @waterlubber, do you remember what you did in gtk-theme-config? I installed it but I found no option for menu texts background and foreground colors, only one option for menu text color.

image

waterlubber commented 6 years ago

Those are the options I've changed -- sorry, I've been out for the past week.

Anyway, if you turn on custom panel/menu colors and change the menu background color you should be good. Just play with the options, I guess.

pedrohasantiago commented 6 years ago

gtk-theme-config allows me to change the color for "unavailable" menu options (I don't know if that's the proper word), but not for the available ones. I tried every option, but this text color remains inaccessible: screenshot at 2018-08-12 23-27-12

To be able to properly see the available menu options, I have to change the menu background, which is something I don't want to do. I like the original background color. screenshot at 2018-08-12 23-29-40

Unfortunately, I don't have enough GTK knowledge to contribute with a solution :(

waterlubber commented 6 years ago

Ohhh, I changed the menu background to a dark theme: image This makes everything visible and it blends in great with the dark menubar.

Edit: And for whatever reason these changes are disabled, but it still works. This is more confusing than I thought...

NicoHood commented 6 years ago

Can we close this?