search

arc-pune / arc-front-end

A Website to help pets find their new home.
https://arc-pune.vercel.app/
MIT License
18 stars 26 forks source link

Change the theme toggle icon #132

Closed agarwalsahil0210 closed 2 years ago

agarwalsahil0210 commented 2 years ago

A relevant icon for changing the theme from light to dark mode and vice-versa.

timagixe commented 2 years ago

@agarwalsahil0210 hi, is there any specific icon you want to be used for theme switcher?

Or those can be sun / moon icons of heroicons?

Should different icons to be displayed for different active theme? (i.e. when active light theme the moon icon should be displayed, when active dark theme the sun icon should be displayed)

agarwalsahil0210 commented 2 years ago

@agarwalsahil0210 hi, is there any specific icon you want to be used for theme switcher?

Or those can be sun / moon icons of heroicons?

Should different icons to be displayed for different active theme? (i.e. when active light theme the moon icon should be displayed, when active dark theme the sun icon should be displayed)

Hey @timagixe you got that. There should be different icons displayed for different active theme. And the sun / moon icons would work!. Should i assign you this?

timagixe commented 2 years ago

@agarwalsahil0210 yes, please. Would be happy to contribute.

agarwalsahil0210 commented 2 years ago

@agarwalsahil0210 yes, please. Would be happy to contribute.

Okay I've assigned this to you . Just once go through Contributing.md and get started. Happy Coding!

timagixe commented 2 years ago

@agarwalsahil0210 I did the job in #136. Please take a look once you have a chance.

agarwalsahil0210 commented 2 years ago

@agarwalsahil0210 I did the job in #136. Please take a look once you have a chance.

Okay that seems pretty good. I'll be merging this. Thanks for your contribution! Cheers!