search

arc53 / DocsGPT

Chatbot for documentation, that allows you to chat with your data. Privately deployable, provides AI knowledge sharing and integrates knowledge into your AI workflow
https://app.docsgpt.cloud/
MIT License
15.05k stars 1.61k forks source link

fix milvus issues #1407

Closed zc277584121 closed 2 weeks ago

zc277584121 commented 3 weeks ago

  1. argument filter is not in the _docsearch.similarity_search(), instead , we can use expr

  2. add dependency inrequirements.txt

vercel[bot] commented 3 weeks ago

@zc277584121 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

zc277584121 commented 3 weeks ago

Hi @dartpain , could you (or anyone) please take a review

dartpain commented 2 weeks ago

Good pr, thank you. Can we remove milvius as a dependency please from requirements.txt, as we want to keep it lazy loaded.

zc277584121 commented 2 weeks ago

@dartpain thank you, I have removed it , please review again

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.02%. Comparing base (0425190) to head (7fd8e57). Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
application/vectorstore/milvus.py 25.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1407 +/- ## ========================================== - Coverage 34.03% 34.02% -0.02% ========================================== Files 69 69 Lines 3376 3377 +1 ========================================== Hits 1149 1149 - Misses 2227 2228 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dartpain commented 2 weeks ago

@holopin-bot @zc277584121 Thank you!

holopin-bot[bot] commented 2 weeks ago

Congratulations @zc277584121, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm38qnnu584810cl80j27mh8i

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

dartpain commented 2 weeks ago

Hey @zc277584121 please fill in this form if you are interested in a t-shirt https://airtable.com/appikMaJwdHhC1SDP/pagoblCJ9W29wf6Hf/form

zc277584121 commented 2 weeks ago

Hey @zc277584121 please fill in this form if you are interested in a t-shirt请填写此表单，如果您对购买 T 恤感兴趣 https://airtable.com/appikMaJwdHhC1SDP/pagoblCJ9W29wf6Hf/form

thank you