feat: wrapper modal - Githubissues

arc53 / DocsGPT

Chatbot for documentation, that allows you to chat with your data. Privately deployable, provides AI knowledge sharing and integrates knowledge into your AI workflow

https://app.docsgpt.cloud/

MIT License

15.04k stars 1.6k forks source link

feat: wrapper modal #1434

Closed RohittCodes closed 2 days ago

RohittCodes commented 1 week ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) this pr introduces a wrapper modal, which will act as a base for every other modals. includes functionality to close the modal on a click outside the modal or an ESC key press.
Why was this change needed? (You can also link to an open issue here) fixes: #1231
Other information:

vercel[bot] commented 1 week ago

@RohittCodes is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.89%. Comparing base (70f44fc) to head (04959df). Report is 62 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1434 +/- ## ========================================== - Coverage 34.02% 33.89% -0.13% ========================================== Files 69 70 +1 Lines 3377 3440 +63 ========================================== + Hits 1149 1166 +17 - Misses 2228 2274 +46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-gpt	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 17, 2024 11:22pm

RohittCodes commented 6 days ago

@ManishMadan2882 should I try adding something to prevent the modal from closing while training and upload?

ManishMadan2882 commented 6 days ago

@RohittCodes Yes, we should avoid closing of the modal while upload/train is in process, good catch!