arc53 / DocsGPT

Chatbot for documentation, that allows you to chat with your data. Privately deployable, provides AI knowledge sharing and integrates knowledge into your AI workflow
https://app.docsgpt.cloud/
MIT License
14.98k stars 1.59k forks source link

🚀 Feature: Creating a Separate page for Signup and Signin #611

Closed Hemant2335 closed 5 months ago

Hemant2335 commented 1 year ago

🔖 Feature description

This feature brings more Interactivity into the website for the users because in current state it looks no so good to just click over there and get a popped out signup and signin page so i can create a new page for that purpose with some great UI and will try to keep the same vibe with that page too

🎤 Why is this feature needed ?

This feature is needed for the future developments like in future you might wanted to add some more things to the Homepage then it might not be the good idea to keep signup and signin button on the homepage itself

✌️ How do you aim to achieve this?

As I am quite proficient in react and tailwind and using these I can easily achieve this .

🔄️ Additional Information

Please assign this issue to me

👀 Have you spent some time to check if this feature request has been raised before?

Are you willing to submit PR?

Yes I am willing to submit a PR!

codeslayed commented 1 year ago

yes please assign me this

dartpain commented 1 year ago

@Hemant2335 I really do appreciate your enthusiasm. Please create UI first, just simple mock desing such that @tenokami can approve it and the you can proceed with the chages.

Hemant2335 commented 1 year ago

@Hemant2335 I really do appreciate your enthusiasm. Please create UI first, just simple mock desing such that @tenokami can approve it and the you can proceed with the chages.

Okk I am on it

Hemant2335 commented 1 year ago

I have created a figma design link : https://www.figma.com/file/I6CU2tCjvjUvbvFzukRGWR/Login_mockup?type=design&node-id=0%3A1&mode=design&t=Sos0T5JhsDwPIDMS-1

And mockup image :

Group 7

If any suggestions please let me know

tenokami commented 1 year ago

@Hemant2335 Thank you!

Mainly easily fixable design consistency issues with our style

Font looks too bold comparatively to what we have in docsgpt. "Continue" should be our main purple color

For more consistency we could use the same MUI style input fields that are already in DocsGPT

"Or continue with" I'd prefer not to use capitalization on every word here cause it lowers readability

The illustration on the right could be replaced with something more "on brand" Like some art we have on tshirts @dartpain

I don't see the "forgot password" button. We can have it right? @dartpain

I'd replace icons. I'd go with something more minimalistic

tenokami commented 1 year ago

@Hemant2335 Would you be so kind to update the design according to this feedback?

After that Ill polish it up and maybe we can proceed with implementation

Hemant2335 commented 1 year ago

Thank you for the feedback, I'll be updating you soon

Hemant2335 commented 1 year ago

I have Made the required changes the updated image :

Group 3

If I left something or misinterpreted , please let me know

Thank you

tenokami commented 1 year ago

@dartpain What picture would you like to use on the right

tenokami commented 1 year ago

@Hemant2335 Thank you. I will polish this and then let you know when it is ready for implementation

Hemant2335 commented 1 year ago

Ok I'll catch you from there

jamsnrihk commented 1 year ago

@Hemant2335 Thank you. I will polish this and then let you know when it is ready for implementation

any update for this?

Hemant2335 commented 1 year ago

No reply came from @tenokami regarding design

tenokami commented 1 year ago

No reply came from @tenokami regarding design

I apologize for giving no response. I need to confirm something regarding updating the design of authorization and then I'll respond

Hemant2335 commented 1 year ago

Okay got it

dartpain commented 12 months ago

I think @tenokami can advise in terms of desing, but I want something simple, maybe just a form in a middle

tenokami commented 12 months ago

@Hemant2335 Thank you for waiting!

The design for Login/Registration is here at the bottom

It includes hover and select effects. The state when input is active and for error states. Also validation text is at the end

Hemant2335 commented 11 months ago

Okk Thank you @tenokami , Should I start Working on the same

tenokami commented 11 months ago

@Hemant2335 We would appreciate it!

Rutam21 commented 10 months ago

@tenokami This issue can be closed now as the changes are merged in https://github.com/arc53/DocsGPT/pull/799