search

arcadefire / nice-spinner

A nice spinner for Android
Apache License 2.0
2.85k stars 445 forks source link

fixed Spinner pop up issue on Dialogs #123

Closed tanoDxyz closed 5 years ago

tanoDxyz commented 5 years ago

when spinner is shown in layouts that are inflated for Dialogs like Alert dialog...some drop down items were not shown and this is fixed . now spinner behaves as usual on dialogs.

tanoDxyz commented 5 years ago

ok all done mentioned. check it once...

asknask commented 5 years ago

Is this really fixed? I'm using nice spinner inside a MaterialDialog. I have 6 items in my data but the spinner only shows 3.

@arcadefire @tanoDxyz Could you check this?

tanoDxyz commented 5 years ago

Is this really fixed? I'm using nice spinner inside a MaterialDialog. I have 6 items in my data but the spinner only shows 3.

@arcadefire @tanoDxyz Could you check this?

well if the spinner has a new version.

pzienowicz commented 5 years ago

Could you tag the newest version after merge?

And please fix build for the latest tag: https://jitpack.io/com/github/arcadefire/nice-spinner/f1bc07f83d/build.log

souragar commented 4 years ago

This is still not fixed

tanoDxyz commented 4 years ago

This is still not fixed

well i fixed the code but as obvious there's no change in version codes since then . so when you add the dependency you are using the old version . and i believe @arcadefire could fix that.

pzienowicz commented 4 years ago

@arcadefire, could you?

arcadefire commented 4 years ago

Sorry guys, I had literally zero time to dedicate on this project. I've just drafted a new release: https://github.com/arcadefire/nice-spinner/releases/tag/1.4.4.

pzienowicz commented 4 years ago

Thanks @arcadefire, but please make the build passing, because now the tag is not accessible in jitpack: https://jitpack.io/#arcadefire/nice-spinner